Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExpressibleByNilLiteral conformance #4

Merged
merged 3 commits into from
May 25, 2018
Merged

Remove ExpressibleByNilLiteral conformance #4

merged 3 commits into from
May 25, 2018

Conversation

mbrandonw
Copy link
Member

I think we uncovered that we don't actually want this... right?

@mbrandonw mbrandonw requested a review from stephencelis May 9, 2018 02:36
stephencelis
stephencelis approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is prob for the best. Can revisit in the future if we can find a compelling, non-confusing reason for it.

@mbrandonw mbrandonw merged commit a16c777 into master May 25, 2018
@mbrandonw mbrandonw deleted the nil branch May 25, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrandonw @stephencelis