Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md #735

Merged
merged 18 commits into from
Dec 9, 2024
Merged

Updated README.md #735

merged 18 commits into from
Dec 9, 2024

Conversation

PaologGithub
Copy link
Contributor

Hi !!! I updated README.md so it can be newer, with new informations, without breaking the old readme.

I changed the structure tree, so we can add link, and added Documentation section.

Please accept it, it took me a long time to do it :,)

@PaologGithub
Copy link
Contributor Author

Fixed a typo commit was here to fix the "functionnalities" typo I put and that made lint put a cross :,(

@PaologGithub
Copy link
Contributor Author

Fixed samples link on PiPy is because in setup.py, the long pypi description is the content of README.md, but the samples link was at /samples, so it didn't work because pypi didn't have https://pypi.org/samples/minecraft_clone.py or other

@PaologGithub
Copy link
Contributor Author

Same for samples folder link for pypi, I updated the link to be with the GitHub repo URL, not just samples

README.md Outdated
@@ -109,41 +111,62 @@ app.run() # opens a window and starts the game.

To close the window, you can by default, press shift+q or press the red x. to disable this, write `window.exit_button.enabled = False` somewhere in your code.

## Documentation
If you need help, you can watch documentation sites:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the grammar here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not that good in english, what is the error here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to change it to "If you need help, you can refer to the following documentation sites:"

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ItsbaileyX3525
Copy link

That's a lot of commits...

@PaologGithub
Copy link
Contributor Author

That's a lot of commits...

The README.md tells us to install python 3.6, and outdated things, but today Ursina needs python 3.10 (Or python 3.8 if you use PaologGithub/UrsinaForMobile wheel) so it is what this commit do

@pokepetter pokepetter merged commit afafe01 into pokepetter:master Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants