Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Persistence] Deprecate PrePersistence #105

Closed
1 task
Olshansk opened this issue Jul 7, 2022 · 0 comments · Fixed by #140
Closed
1 task

[Persistence] Deprecate PrePersistence #105

Olshansk opened this issue Jul 7, 2022 · 0 comments · Fixed by #140
Assignees
@Olshansk @andrewnguyen22
Labels
code health Nice to have code improvement core Core infrastructure - protocol related persistence Persistence specific changes
Milestone
V1 Persistence Fo...

Comments

@Olshansk
Copy link
Member

Olshansk commented Jul 7, 2022

Objective

Deprecate and remove all PrePersistence related code.

Origin Document

[Persistence] V1 Persistence Foundation Integration Issue

Goals

Deliverables

  • Deprecation of the PrePersistence Module and all related code, docs, resources, etc...

Testing Methodology

LocalNet and Unit Tests. See ./docs/development/README.md for more details.

Non-goals

  • List of goals that this issue won't address

Creator: @Olshansk
Co-Owners: @andrewnguyen22
@Olshansk Olshansk added persistence Persistence specific changes code health Nice to have code improvement priority:high labels Jul 7, 2022
@Olshansk Olshansk added this to the V1 Persistence Foundation milestone Jul 7, 2022
@Olshansk Olshansk self-assigned this Jul 7, 2022
@Olshansk Olshansk added the core Core infrastructure - protocol related label Jul 26, 2022
@Olshansk Olshansk moved this to In Progress in V1 Dashboard Jul 26, 2022
@Olshansk Olshansk mentioned this issue Jul 30, 2022
Closed
This was referenced Aug 3, 2022
Merged
Closed
Repository owner moved this from In Progress to Done in V1 Dashboard Aug 15, 2022
This was referenced Sep 12, 2022
Closed
Closed
Closed
Closed
Closed
@andrewnguyen22 andrewnguyen22 mentioned this issue Oct 19, 2022
Merged
17 tasks
andrewnguyen22 pushed a commit that referenced this issue Oct 19, 2022
issue-#210 (#312)
714df28 
## Description

A general cleanup issue is needed to tackle TODO's and ensure the persistence module is usable/readable by consolidating `Actor` with `BaseActor` as part of #172. 

Follows issue-#128, issue-#105, issue-#147 and issue-#148 the persistence module is messier and more difficult to understand than the developers would want for organic external contribution.

## Issue

Fixes #210 

## Type of change

Please mark the relevant option(s):

- [ ] New feature, functionality or library
- [ ] Bug fix
- [x] Code health or cleanup
- [ ] Major breaking change
- [ ] Documentation
- [ ] Other <!-- add details here if it a different type of change -->

## List of changes

- [x] Consolidate `Actor` in `persistence/schema/base_actor.go` with `BaseActor` in `persistence/schema/base_actor.go`.


## Testing

- [x] `make develop_test`
- [x] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README`

## Required Checklist

- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have tested my changes using the available tooling
- [x] I have updated the corresponding CHANGELOG

### If Applicable Checklist
- [x] I have updated the corresponding README(s); local and/or global
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s)
- [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Olshansk Olshansk

@andrewnguyen22 andrewnguyen22

Labels
code health Nice to have code improvement core Core infrastructure - protocol related persistence Persistence specific changes
Projects
V1 Dashboard
Status: Done
Milestone
V1 Persistence Foundation
2 participants
@Olshansk @andrewnguyen22