-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Configuration] Genesis and Node Configurations (Issue#154) #166
Conversation
#73) ## Objective Foundational iteration of PostgreSQL based persistence module implementation. ## Origin Document #68 ## Type of change New major module implementation. ### Persistence-related core changes: - List of actors / interfaces with MVP implementation: - Applications - Fisherman - ServiceNode - Accounts - Pools - List of actors / interfaces with partial MVP implementation: - Validator - Gov params - List of actors / interfaces with minorimplementation: - Block - SQL Schema definition of the actors above - SQL Query implementation for common actor persistence functionality - PostgresContext implementation of the actors actors above - Base infrastructure for fuzz testing Non-persistence “fly-by” changes - Updates to the PrePersistence module and utility module with breaking changes - A few minor improvements/additions to the Makefile - TODOs & comment cleanups throughout the codebase ## How Has This Been Tested? ### Unit Tests ``` make test_persistence make test_all ``` ### LocalNet Ran a basic LocalNet following the instructions in the [development README](docs/development/README.md). Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com> Co-authored-by: Andrew Nguyen <andrewnguyen@Andrews-MacBook-Pro-2.local> Co-authored-by: Andrew Nguyen <andrewnguyen@Andrews-MBP-2.lan> Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
…tence-foundation-interim-merge' into issue-#111
… to read / write separation
Yeah sounds good on the ordering. Like 90% sure you had merged #128 with main and then force pushed it to revert it lol I merged #128 with main so all should be good now |
@andrewnguyen22 As discussed offline, I have done the following:
Once #171 is approved, we can do the following:
Lmk what you think of the plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this merge since #171 is coming in immediately after. Will take care of bringing both of them in.
## Description This is a code review of #166. Rather than leaving comments on the original PR, we are leaving TODOs throughout the code with only a few changes being pushed right now. They will be tended to in this issue: https://github.com/pokt-network/pocket/issues/<ISSUE_NUMBER> ## Type of change Please mark the options that are relevant. - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation - [X] Other: Code cleanup ## How Has This Been Tested? - [ ] `make test_all` - [ ] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) ## Checklist - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have tested my changes using the available tooling - [ ] If applicable, I have made corresponding changes to related or global README - [ ] If applicable, I have added added new diagrams using [mermaid.js](https://mermaid-js.github.io) - [ ] If applicable, I have added tests that prove my fix is effective or that my feature works
Intention
Currently merge ready with #128 but not considering #165 since it's under active development.
Description
closes #154
Type of change
Please mark the options that are relevant.
How Has This Been Tested?
make test_all
&&
make compose_and_watch
make test_all
Checklist