Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make targets for config & genesis generation Issue #182 #207

Merged
merged 8 commits into from
Sep 17, 2022

Conversation

andrewnguyen22
Copy link
Contributor

@andrewnguyen22 andrewnguyen22 commented Sep 12, 2022

Description

In order to test various LocalNet configurations, especially as we start adding different types of protocol actors in the future, we need to be able to build such configurations easily.

An easy-to-use make target to dynamically generate genesis and config files for various LocalNet configurations. This will eventually be used for DevNet as well even though it is out of scope of this PR.

Issue

Fixes #182

Type of change

Please mark the options that are relevant.

  • New feature, functionality or library
  • Bug fix (non-breaking change which fixes an issue)
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other: <REPLACE_ME>

List of changes

  • Added make target for genesis and config generation in build/config
  • Document parameters and usage with README.md

Testing

  • make test_all
  • LocalNet w/ all of the steps outlined in the README
  • make genesis_and_config

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • If applicable, I have made corresponding changes to related local or global README

Co-authored-by: Andrew Nguyen andrewnguyen@Andrews-MacBook-Pro-2.local
Co-authored-by: Daniel Olshansky olshansky.daniel@gmail.com

@andrewnguyen22 andrewnguyen22 requested a review from a team as a code owner September 12, 2022 15:47
@andrewnguyen22 andrewnguyen22 changed the base branch from main to issue-#163 September 12, 2022 15:47
@andrewnguyen22 andrewnguyen22 self-assigned this Sep 12, 2022
@andrewnguyen22 andrewnguyen22 added the tooling tooling to support development, testing et al label Sep 12, 2022
@Olshansk Olshansk requested review from okdas and removed request for deblasis September 12, 2022 22:16
Base automatically changed from issue-#163 to main September 14, 2022 16:55
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a small non-crucial PR, I made a few changes using my best judgment so as to not waste your time replying to the comments. PTAL and let me know if you disagree on any points

@andrewnguyen22 andrewnguyen22 merged commit 60a6831 into main Sep 17, 2022
@andrewnguyen22 andrewnguyen22 deleted the issue-#182 branch September 17, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling tooling to support development, testing et al
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Config] Add make targets for config & genesis generation
2 participants