-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCUMENT] Interfaces for the M3 Relay Protocol (issue-#265) #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed utility/service/service.go
yet but left some comments on utility/service/README.md
and figured I'd submit a first review.
Most NITS, a couple questions, and just one idea I wanted to get your thoughts on.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage ? 40.06%
=======================================
Files ? 28
Lines ? 2184
Branches ? 0
=======================================
Hits ? 875
Misses ? 1255
Partials ? 54 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
utility/service/PROTOCOLS.md
Outdated
|
||
1) Validate payload, look for empty or 'bad' request data | ||
2) Validate the metadata, look for empty or 'bad' metadata | ||
3) Ensure the `RelayChain` is supported locally (in the service node's configuration files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be from config files from the on-chain state?
Asking because we store the supported RelayChains
on chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's both technically, but definitely locally is a validation point
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Approved with one minor remaining NIT. |
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
Description
Code / document interfaces for the Relay Protocol to enable consensus and understanding around this piece of the M3 milestone.
M3 Milestone
This is the first step into beginning the Relay Protocol development.
Issue
Fixes #265
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test
README
Required Checklist
If Applicable Checklist
shared/docs/*
if I updatedshared/*
README(s)