feat(rust, python)!: Cut label formatting #10083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magarick
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
github-actions
bot
added
breaking
|
@ritchie46 ping! |
magarick
force-pushed
the
cut-label-formatting
branch
from
33cb37a
to
c366c58
Compare
|
Rebased on the latest changes. Nothing too controversial here. Though if there's a way to more efficiently format the strings in rust that would be nice at some point. |
magarick
force-pushed
the
cut-label-formatting
branch
from
95512aa
to
aff2336
Compare
|
Going to close this in light of the pending redesign (#10468) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels in cut and qcut can now be formatted with variable precision. They can also optionally use scientific notation. Technically this is breaking since I had to pick a default for precision and set it at 3, but I don't think anyone actually wanted the old behavior anyway.
If there's a way to make the string processing on the Rust side better I'd love to hear it. Because string formatting in Rust is torture and I tried but couldn't find anything easier than what I ended up with.