-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depr(python): Deprecate some parameters of cut
/qcut
#10484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deprecation
Add a deprecation warning to outdated functionality
python
Related to Python Polars
labels
Aug 14, 2023
stinodego
force-pushed
the
cut-qcut
branch
3 times, most recently
from
August 14, 2023 18:38
bf0409d
to
8c216c0
Compare
Would this be a breaking change since some people seemed to be depending on the old behavior. I don't know why but that's why I kept it as an option. |
magarick
reviewed
Aug 14, 2023
This is just a deprecation. It would normally to be followed by a breaking change to actually remove the deprecated behavior. |
magarick
reviewed
Aug 15, 2023
magarick
reviewed
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #10468
Changes
series
parameter toas_series
and deprecate it. This is a remnant of the oldpl.cut
function. The method should just return a Series - possibly a struct Series ifinclude_breaks=True
.as_series
is removed).category_label
andbreak_point_label
. This is unnecessary parameter bloat. We should set sensible naming defaults and allow the user to overwrite it withSeries.struct.rename_fields
if they want.To do, in a different PR:
quantiles
forqcut
into two parameters -probabilities
andn_bins
(not 100% sure about the names).