feat!: Rename cut
/qcut
struct fields
#10520
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
include_breaks=True
, the output ofcut
/qcut
is a struct. This improves the field names:brk
->break
NAME_bin
->category
I believe this change is mild enough to be included without a prior deprecation warning.
Related: the design of these functions breaks our premise of one expression = one data type. The Lazy schema is incorrect too. But this is a separate discussion.