fix(rust, python): Take input_schema to create physical expr for Selection #10571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reswqa
requested review from
ritchie46,
stinodego,
alexander-beedie and
orlp
as code owners
github-actions
bot
added
fix
reswqa
commented
Aug 17, 2023
| predicate, | ||
| Context::Default, | ||
| expr_arena, | ||
| Some(&input_schema), |
There was a problem hiding this comment.
I'm not sure if it's due to some reason I don't know that we didn't pass input_schema here. 🤔
|
Looks good to me and all tests pass, so let's merge this. |
orlp
approved these changes
Aug 17, 2023
ritchie46
reviewed
Aug 17, 2023
| @@ -165,10 +165,16 @@ pub fn create_physical_plan( | |||
| Ok(Box::new(executors::SliceExec { input, offset, len })) | |||
| }, | |||
| Selection { input, predicate } => { | |||
| let input_schema = lp_arena.get(input).schema(lp_arena).into_owned(); | |||
There was a problem hiding this comment.
Do we really need to clone here? As we pass by reference a few lines later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #10565.