Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rust, python): supports cast to list #10623

Merged
merged 4 commits into from
Aug 21, 2023
Merged

feat(rust, python): supports cast to list #10623

merged 4 commits into from
Aug 21, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Aug 20, 2023 •
edited
Loading

This closes #10611.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Aug 20, 2023
@reswqa
Copy link
Collaborator Author

reswqa commented Aug 20, 2023

Something is unexpected, let me take a look.

@reswqa
Copy link
Collaborator Author

reswqa commented Aug 20, 2023

Fixed on upstream in: jorgecarleitao/arrow2#1550

@reswqa
Copy link
Collaborator Author

reswqa commented Aug 21, 2023

@ritchie46 Finally, all checks have passed. 😌

stinodego
stinodego requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a minor detail for the test case.

py-polars/tests/unit/datatypes/test_list.py Outdated Show resolved Hide resolved
stinodego
stinodego approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@stinodego stinodego merged commit 4b388e3 into pola-rs:main Aug 21, 2023
22 checks passed
@reswqa reswqa deleted the cast_list branch August 21, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exceptions.ArrowErrorException: NotYetImplemented("Casting from ... to LargeList(Field { ... not supported")
2 participants
@reswqa @stinodego