Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): Explicitly implement Protocol for interchange classes #10688

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Aug 23, 2023

This will be useful for type checking the from_dataframe implementation I am working on. And this verifies our the API of our interchange object is correct.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Aug 23, 2023
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Aug 23, 2023

Protocols FTW! Will approve if you can tidy up the last few tests :)

@stinodego
Copy link
Member Author

stinodego commented Aug 23, 2023

Protocols FTW! Will approve if you can tidy up the last few tests :)

I think a new pandas version is mucking up the CI. Will take a look!

EDIT: It was a new pyarrow version 😄

@stinodego stinodego merged commit f80e6e0 into main Aug 23, 2023
11 of 12 checks passed
@stinodego stinodego deleted the protocol-implementation branch August 23, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants