Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): raise exception with invalid on arg type for join_asof #10690

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix(python): raise exception with invalid on arg type for join_asof #10690

merged 1 commit into from
Aug 24, 2023

Conversation

mcrumiller
Copy link
Contributor

Resolves #10687

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Aug 23, 2023
@mcrumiller
Copy link
Contributor Author

Anyone know why to_pandas test is failing, unrelated to my PR? I rebased off of main.

@reswqa
Copy link
Collaborator

reswqa commented Aug 23, 2023

Anyone know why to_pandas test is failing, unrelated to my PR

I think it is unrelated. It seems that several recent PRs have failed due to the same issue.

ritchie46
ritchie46 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @mcrumiller

@ritchie46 ritchie46 merged commit 576ed0d into pola-rs:main Aug 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

join_asof: Check that left_on/right_on are strings
3 participants
@mcrumiller @reswqa @ritchie46