Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust, python): Reused input series in rolling_apply should not be orderly #10694

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix(rust, python): Reused input series in rolling_apply should not be orderly #10694

merged 2 commits into from
Aug 24, 2023

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Aug 23, 2023

This fixes #10681.

@reswqa reswqa marked this pull request as draft August 23, 2023 16:08
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Aug 23, 2023
@reswqa reswqa marked this pull request as ready for review August 23, 2023 16:54
@ritchie46 ritchie46 merged commit 0682315 into pola-rs:main Aug 24, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@stinodego stinodego Awaiting requested review from stinodego

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong results for rolling_apply, when using min() as apply function.
2 participants
@reswqa @ritchie46