Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(python): refactored write_database unit tests to properly separate concerns #10773

Merged
merged 4 commits into from
Aug 29, 2023
Merged

test(python): refactored write_database unit tests to properly separate concerns #10773

merged 4 commits into from
Aug 29, 2023

Conversation

alexander-beedie
Copy link
Collaborator

Ref: #10763.

Splits the single "write database" unit test into the following:

  • test_write_database_create
  • test_write_database_append
  • test_write_database_create_quoted_tablename
  • test_write_database_errors

Due to apache/arrow-adbc#1000, the test_write_database_create_quoted_tablename check is skipped when run for adbc_driver_sqlite version 0.6.0.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Aug 29, 2023
stinodego
stinodego reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I just have one minor comment, otherwise good to go.

py-polars/tests/unit/io/test_database_write.py Outdated Show resolved Hide resolved
stinodego
stinodego approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stinodego stinodego merged commit 4963a43 into pola-rs:main Aug 29, 2023
12 checks passed
@alexander-beedie alexander-beedie deleted the refactor-write-database-tests branch August 29, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-beedie @stinodego