fix(rust,python): streamline is_in handling of mismatched dtypes and fix a minor regression
#11533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego and
orlp
as code owners
github-actions
bot
added
fix
alexander-beedie
force-pushed
the
streamline-mismatched-is-in
branch
from
aa0e3aa
to
e57d500
Compare
alexander-beedie
force-pushed
the
streamline-mismatched-is-in
branch
from
6145165
to
1486d8a
Compare
ritchie46
approved these changes
Oct 5, 2023
orlp
pushed a commit
to orlp/polars
that referenced
this pull request
Oct 5, 2023
…d fix a minor regression (pola-rs#11533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11523.
Revisits #11427 and cleans things up while addressing the linked regression. Cleaner dtype match branches now, resulting in more obvious (and less) code, with additional
is_intest coverage for list dtype.