chore(python): Disable type checking for dataframe_api_compat dependency
#11997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46 and
alexander-beedie
as code owners
github-actions
bot
added
internal
stinodego
force-pushed
the
fix-mypy-issue
branch
from
dfecd1d
to
da071f6
Compare
stinodego
force-pushed
the
fix-mypy-issue
branch
from
da071f6
to
e3948cc
Compare
stinodego
changed the title
dataframe_api_compat dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second time this package breaks our CI due to type hint issues.
I opened a PR in the repo to fix this specific one, but it seems that there is no type checking in their CI. So I think it's best to turn off type checking for this package until the type hints are more reliable.
@MarcoGorelli FYI - I don't mind helping out a bit in that repo with regards to type hints, with the Polars side of things at least. Let me know if there is something I can help you with.