Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update dprint hook versions and enable JSON linting #16611

Merged
merged 2 commits into from
May 31, 2024
Merged

chore: Update dprint hook versions and enable JSON linting #16611

merged 2 commits into from
May 31, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented May 30, 2024 •
edited
Loading

Apparently the new TOML formatter does some sorting within Cargo.toml files, which is nice.

I enabled JSON formatting - we don't have a lot of JSON files but it can't hurt.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels May 30, 2024
@stinodego stinodego marked this pull request as ready for review May 30, 2024 22:28
@ritchie46 ritchie46 merged commit bfcc1ee into main May 31, 2024
28 checks passed
@ritchie46 ritchie46 deleted the dprint branch May 31, 2024 08:27
@c-peters c-peters added the accepted Ready for implementation label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@stinodego stinodego

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stinodego @ritchie46 @c-peters