Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix mean reduction in new-streaming #18572

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 5, 2024

Now using _sum_as_f64 and making sure to get the dtype from the input rather than the output (which is different for Dates).

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (c85b338) to head (9784d2b).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/convert.rs 0.00% 17 Missing ⚠️
.../polars-core/src/series/implementations/boolean.rs 0.00% 3 Missing ⚠️
...tes/polars-core/src/series/implementations/date.rs 0.00% 3 Missing ⚠️
...polars-core/src/series/implementations/datetime.rs 0.00% 3 Missing ⚠️
.../polars-core/src/series/implementations/decimal.rs 0.00% 3 Missing ⚠️
...polars-core/src/series/implementations/duration.rs 0.00% 3 Missing ⚠️
...s/polars-core/src/series/implementations/floats.rs 0.00% 3 Missing ⚠️
...ates/polars-core/src/series/implementations/mod.rs 0.00% 3 Missing ⚠️
...tes/polars-core/src/series/implementations/time.rs 0.00% 3 Missing ⚠️
crates/polars-core/src/series/series_trait.rs 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18572   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files        1501     1501           
  Lines      201736   201764   +28     
  Branches     2869     2869           
=======================================
+ Hits       161059   161097   +38     
+ Misses      40131    40121   -10     
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 76b8f46 into pola-rs:main Sep 5, 2024
22 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants