Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add pre-filtered decode to new parquet source #18715

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

nameexhaustion
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 17.81377% with 203 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (0e5e554) to head (04b29fe).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...tream/src/nodes/parquet_source/row_group_decode.rs 0.00% 135 Missing ⚠️
...tes/polars-stream/src/nodes/parquet_source/init.rs 0.00% 62 Missing ⚠️
crates/polars-io/src/parquet/read/read_impl.rs 87.50% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18715      +/-   ##
==========================================
- Coverage   79.90%   79.81%   -0.10%     
==========================================
  Files        1513     1513              
  Lines      203465   203663     +198     
  Branches     2892     2892              
==========================================
- Hits       162579   162551      -28     
- Misses      40338    40564     +226     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 12, 2024 11:22
@nameexhaustion nameexhaustion marked this pull request as draft September 12, 2024 11:23
@@ -287,12 +288,69 @@ impl ParquetSourceNode {
let ideal_morsel_size = get_ideal_morsel_size();
let min_values_per_thread = self.config.min_values_per_thread;

let use_prefiltered = physical_predicate.is_some()
let mut use_prefiltered = physical_predicate.is_some()
&& matches!(
self.options.parallel,
ParallelStrategy::Auto | ParallelStrategy::Prefiltered
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently enables pre-filtering by default on new-streaming

@nameexhaustion nameexhaustion marked this pull request as draft September 12, 2024 14:16
@nameexhaustion nameexhaustion marked this pull request as ready for review September 12, 2024 14:19
@ritchie46 ritchie46 merged commit a8e18e6 into pola-rs:main Sep 13, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 16, 2024
nameexhaustion added a commit to nameexhaustion/polars that referenced this pull request Sep 16, 2024
@nameexhaustion nameexhaustion deleted the pqs-prefilter branch September 27, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants