Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Remove note about guaranteed left join order #20048

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Nov 28, 2024

Ref #19576

We currently guarantee preserving the order on a left join. In the future, we will no longer guarantee this by default and add a maintain_order argument to control this, as guaranteeing the order can be expensive under certain conditions.

So I'm removing the note about the guarantee from the docs at this time. The order will still be preserved for now, but users should not blindly rely on this as it will break in the future.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars labels Nov 28, 2024
@stinodego stinodego marked this pull request as ready for review November 28, 2024 12:55
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (83b5042) to head (efd24ec).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20048   +/-   ##
=======================================
  Coverage   79.50%   79.50%           
=======================================
  Files        1562     1562           
  Lines      216943   216943           
  Branches     2459     2459           
=======================================
+ Hits       172477   172487   +10     
+ Misses      43907    43897   -10     
  Partials      559      559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 9f3f012 into main Nov 28, 2024
16 checks passed
@ritchie46 ritchie46 deleted the remove-join-order-guarantee branch November 28, 2024 12:59
@c-peters c-peters added the accepted Ready for implementation label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation documentation Improvements or additions to documentation python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants