Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Make arange an alias for int_range #9983

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat!: Make arange an alias for int_range #9983

merged 1 commit into from
Aug 16, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 20, 2023 •
edited
Loading

BREAKING

Changes:

  • arange no longer switches between int_range and int_ranges depending on the input. It is now a proper alias for int_range.

@stinodego stinodego added the breaking Change that breaks backwards compatibility label Jul 20, 2023
@stinodego stinodego changed the title refactor!: Make arange an alias for int_range feat!: Make arange an alias for int_range Jul 20, 2023
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jul 20, 2023
@stinodego stinodego force-pushed the breaking-arange-alias branch 2 times, most recently from 10a71ee to b77bbfc Compare July 20, 2023 02:27
@MarcoGorelli
Copy link
Collaborator

nice - does this need to wait for 1.0?

@stinodego
Copy link
Member Author

It's a breaking change in an often used function, so we'll have to wait for the next breaking release - either 1.0.0 or 0.19.0 if we decide to have another in-between release.

@stinodego stinodego requested a review from orlp as a code owner August 15, 2023 08:53
@stinodego stinodego added this to the Python Polars 0.19.0 milestone Aug 16, 2023
@stinodego stinodego merged commit 6095ea5 into main Aug 16, 2023
24 checks passed
@stinodego stinodego deleted the breaking-arange-alias branch August 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @MarcoGorelli