Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support download controller-gen #39

Merged
merged 1 commit into from
May 8, 2024

Conversation

free6om
Copy link
Collaborator

@free6om free6om commented May 8, 2024

The current CRD was generated using controller-gen version 0.9.0, assuming that the developer has already installed it in the shell's PATH directory. This creates two problems:

  1. If it is not installed, it needs to be installed first.
  2. If a different version is already installed locally, the issue of version inconsistency needs to be considered.

The purpose of this PR is to address the above two problems.

The solution is as follows:
Add the download-controller-gen command to the Makefile, which will download controller-gen version 0.9.0 to the bin directory of the project. The make manifests command will use the controller-gen from the bin directory.

@free6om free6om self-assigned this May 8, 2024
@free6om free6om requested a review from dingfeng May 8, 2024 05:38
@dingfeng
Copy link
Collaborator

dingfeng commented May 8, 2024

Hi, @free6om Thanks for your PR.

It works and will be merged after test cases all pass.

@dingfeng dingfeng merged commit 0c2e50a into main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants