Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS & ACL options to healthcheck's redis configuration #398

Closed
magederek opened this issue May 31, 2022 · 0 comments · Fixed by #403
Closed

Add TLS & ACL options to healthcheck's redis configuration #398

magederek opened this issue May 31, 2022 · 0 comments · Fixed by #403
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@magederek
Copy link
Contributor

What is the feature you want to add?
TLS & ACL configuration of healthcheck redis

Why do you want to add this feature?
In some scenario, e.g. when using the Amazon MemoryDB for Redis, we want to enable the TLS and ACL feature for authorization. However, till v1.8.0, the configuration of Redis only containes address, password and some other timeout options, which does not satisfy our demands.

current redis options of polaris healthcheck in polaris-server.yaml:

    healthcheck:
      checkers:
      - name: heartbeatRedis
        option:
          kvAddr: ##REDIS_ADDR##
          kvPasswd: ##REDIS_PWD##
          maxIdle: 200
          idleTimeout: 120s
          connectTimeout: 200ms
          msgTimeout: 200ms
          concurrency: 200

How to implement this feature?
Add TLS & ACL options to healthcheck's redis configuration, make it available to set tls and acl options via polaris-server.yaml

Additional context
TLS: redis-cli --tls
ACL: redis-cli --user USER -a PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants