Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tls and acl options to redis configuration #403

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

magederek
Copy link
Contributor

Please provide issue(s) of this PR:
Fixes #398

new config of healthcheck's redis:

    healthcheck:
      checkers:
      - name: heartbeatRedis
        option:
          kvAddr: ##REDIS_ADDR##
          kvUser: ##REDIS_USER## # ACL user from redis v6.0, remove it if ACL is not available
          kvPasswd: ##REDIS_PWD## # AUTH password below redis v6.0, or ACL password from redis v6.0
          maxIdle: 200
          idleTimeout: 120s
          connectTimeout: 200ms
          msgTimeout: 200ms
          concurrency: 200
          withTLS: false # whether to enable tls

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun chuntaojun added enhancement New feature or request healthcheck labels Jun 2, 2022
@daheige daheige mentioned this pull request Jun 4, 2022
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit 4de6409 into polarismesh:main Jun 6, 2022
daheige pushed a commit to daheige/polaris that referenced this pull request Jun 7, 2022
feat: add tls and acl options to redis configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TLS & ACL options to healthcheck's redis configuration
3 participants