Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize representation usage #2

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Normalize representation usage #2

merged 1 commit into from
Aug 11, 2023

Conversation

polazarus
Copy link
Owner

Short strings should always either be borrowed or inlined but never allocated...

src/bytes.rs Fixed Show fixed Hide fixed
src/raw.rs Fixed Show fixed Hide fixed
src/raw.rs Fixed Show fixed Hide fixed
src/raw.rs Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e10d681). Click here to learn what that means.
The diff coverage is 91.35%.

❗ Current head 7a8c6b9 differs from pull request most recent head ed730f0. Consider uploading reports for the commit ed730f0 to get more accurate results

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   96.94%           
=======================================
  Files           ?       13           
  Lines           ?     2193           
  Branches        ?     2193           
=======================================
  Hits            ?     2126           
  Misses          ?       31           
  Partials        ?       36           
Files Changed Coverage Δ
src/string.rs 96.71% <87.50%> (ø)
src/bytes.rs 96.61% <89.18%> (ø)
src/bytes/convert.rs 100.00% <100.00%> (ø)
src/raw.rs 100.00% <100.00%> (ø)
src/string/convert.rs 98.42% <100.00%> (ø)

@polazarus polazarus force-pushed the dev-normalize branch 2 times, most recently from c8f582c to 50fc2b4 Compare August 11, 2023 21:24
@polazarus polazarus marked this pull request as ready for review August 11, 2023 21:30
@polazarus polazarus force-pushed the dev-normalize branch 3 times, most recently from 7a8c6b9 to 5cbb78f Compare August 11, 2023 21:51
@polazarus polazarus merged commit 6f4f688 into main Aug 11, 2023
36 of 37 checks passed
@polazarus polazarus deleted the dev-normalize branch August 15, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants