Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add biosphere_name argument to NewDatabase #167

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

TimoDiepers
Copy link
Contributor

The biosphere_name is a class variable in NewDatabase, but there is no optional argument for the biosphere_name in the init. Instead, the check_presence_of_biosphere_database function checks for the default name "biosphere3" and asks for user input if it's not present.

I think adding biosphere_name as an optional argument to NewDatabase would be nice to avoid stopping for user inputs when running a script. In my case, I used the ecoinvent_interface to get ei releases. There, the default name of the biosphere is not "biosphere3" anymore, so for me the name input always popped up when creating the premise dbs.

The default behavior of the proposed solution is the same as before, It just allows for defining a custom biosphere name beforehand.

@romainsacchi romainsacchi merged commit 18712d4 into polca:master Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants