add biosphere_name argument to NewDatabase #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biosphere_name is a class variable in NewDatabase, but there is no optional argument for the biosphere_name in the init. Instead, the check_presence_of_biosphere_database function checks for the default name "biosphere3" and asks for user input if it's not present.
I think adding biosphere_name as an optional argument to NewDatabase would be nice to avoid stopping for user inputs when running a script. In my case, I used the ecoinvent_interface to get ei releases. There, the default name of the biosphere is not "biosphere3" anymore, so for me the name input always popped up when creating the premise dbs.
The default behavior of the proposed solution is the same as before, It just allows for defining a custom biosphere name beforehand.