Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.14.0] User Usability Testing Fixes and GA Updates #224

Merged
merged 13 commits into from
Jan 17, 2024

Conversation

pengyin-shan
Copy link
Collaborator

@pengyin-shan pengyin-shan commented Dec 18, 2023

This PR includes:

UAT Test Fixes

  • Based on the user feasibility testing result, adjusted all tables to have a similar header style#233
  • Based on the user feasibility testing result, adjusted the pie chart color at Conservation pages#230
  • Based on the user feasibility testing result, adjusted the side menu style at Conservation pages#229
  • Based on the user feasibility testing result, adjusted tooltip styles for all maps #232

Minor Updates

  • Fixed the loss ratio representation at crop insurance page #225
  • Changed Google Analytics plugin from react-ga module to script and use webpack environmental variable to config #226

@pengyin-shan pengyin-shan self-assigned this Dec 18, 2023
parent ce8d347
author Wendy(Pengyin) Shan <wendy.shan@hotmail.com> 1703105513 -0600
committer Wendy(Pengyin) Shan <wendy.shan@hotmail.com> 1703190129 -0600
@pengyin-shan pengyin-shan changed the title [WIP] move reactga to useEffect part to debug [0.14.0] UAT Test Fixes and GA Updates Jan 17, 2024
@pengyin-shan pengyin-shan marked this pull request as ready for review January 17, 2024 17:17
Copy link
Member

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small feedback about the PR. Based on the description from Leigh during this week's meeting, I feel it would be good to update the PR title and description as "Usability" testing and not UAT, which stands for User Acceptance Testing.

I briefly went through the code and the deployed dev instance. This PR looks good to me otherwise. I will approve. Thanks.

Copy link
Contributor

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the different page update and it looks good overall to me. I didn't notice any issues.

@pengyin-shan pengyin-shan changed the title [0.14.0] UAT Test Fixes and GA Updates [0.14.0] User Usability Testing Fixes and GA Updates Jan 17, 2024
@pengyin-shan pengyin-shan merged commit c3182f9 into develop Jan 17, 2024
3 checks passed
@pengyin-shan pengyin-shan deleted the ga-react_test branch January 17, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants