Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node from 16 directly to 22 #356

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

pengyin-shan
Copy link
Collaborator

@pengyin-shan pengyin-shan commented Dec 17, 2024

This PR addresses #352. It upgrades both the local Node.js version and the Docker Node.js version to Node.js 22. I decided to upgrade directly to this version instead of incrementally upgrading to 18, 20, and then 22, as the process is similar across these versions.

Please note that the GitHub Action for linting remains on Node.js 20, as it is the highest version currently supported by GitHub. However, all actions function as expected.

I have added the upgrade process to README for reference in the future

How to Test

  1. Run export APP_ENV=development in the terminal.
  2. Set your Node.js version to 22.12.0. You may also need to upgrade npm (refer to the updated README for instructions).
  3. Reinstall all Node.js packages.
  4. Run the app locally and test its functionality.
  5. Run the app using Docker and test its functionality.

@pengyin-shan pengyin-shan added this to the 1.6.0 milestone Dec 17, 2024
@pengyin-shan pengyin-shan self-assigned this Dec 17, 2024
@pengyin-shan pengyin-shan changed the title [WIP] try to upgrade node from 16 directly to 22 Upgrade node from 16 directly to 22 Dec 18, 2024
@pengyin-shan pengyin-shan marked this pull request as ready for review December 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant