Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for pulling policies #13

Merged
merged 3 commits into from
Oct 27, 2020
Merged

adds support for pulling policies #13

merged 3 commits into from
Oct 27, 2020

Conversation

xchapter7x
Copy link
Contributor

when a user finds a set of policies using the search
they then want to download them, for local use.
this feature allows them to give a name and a registry
and pull the coresponding policies.

(#6)

  when a user finds a set of policies using the search
  they then want to download them, for local use.
  this feature allows them to give a name and a registry
  and pull the coresponding policies.

  (#6)
@xchapter7x xchapter7x linked an issue Oct 27, 2020 that may be closed by this pull request
Copy link
Contributor

@Blokje5 Blokje5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The Downloader package from conftest indeed makes live simple. I like the tests here, I wasn't aware of the gexec package within Gomega.


func TestMainCLI(t *testing.T) {
gomega.RegisterTestingT(t)
pathToMainCLI, err := gexec.Build("main.go")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never worked with gexec but I like it. I was thinking about adding e.g. BATS to the project, but this works a lot better.

@Blokje5 Blokje5 merged commit 32ed1e0 into main Oct 27, 2020
@xchapter7x xchapter7x deleted the feature/download-policy branch October 27, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a command to download policies
2 participants