Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sql backend optional #1086

Closed
nazar-pc opened this issue Jun 22, 2023 · 4 comments
Closed

Make sql backend optional #1086

nazar-pc opened this issue Jun 22, 2023 · 4 comments

Comments

@nazar-pc
Copy link

Maybe consider making this feature optional? It pulls way too many dependencies, including OpenSSL.

Originally posted by @nazar-pc in #883 (comment)

@sorpaas
Copy link
Member

sorpaas commented Jun 22, 2023

The goal is actually to completely remove the old backend and switch everyone to sql. Do you have any particular reasons not to use the sql backend?

@nazar-pc
Copy link
Author

Hm... not many except it is PITA to deal with OpenSSL when cross-compiling for aarch64 on amd64.

So even though I did not add SQL backend to our service code, it is still pulled in via dependencies, compiled and caused headache that I would rather not have. This is the first and only dependency pulling OpenSSL in our huge monorepo.

vedhavyas added a commit to autonomys/frontier that referenced this issue Jun 23, 2023
Making SQL optional would be great and does not brings unwanted dependencies when SQL is not used. Here is an example: polkadot-evm#1086
sorpaas pushed a commit that referenced this issue Jun 26, 2023
Making SQL optional would be great and does not brings unwanted dependencies when SQL is not used. Here is an example: #1086
@vedhavyas
Copy link
Contributor

vedhavyas commented Jun 26, 2023

This issue was fixed in #1089

@nazar-pc
Copy link
Author

Nice, thank you!

vedhavyas added a commit to autonomys/frontier that referenced this issue Jun 28, 2023
Making SQL optional would be great and does not brings unwanted dependencies when SQL is not used. Here is an example: polkadot-evm#1086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants