Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide a parameter for the runtime config to choose what to include in the PostLog #1014

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Conversation

koushiro
Copy link
Collaborator

@koushiro koushiro commented Mar 7, 2023

See #1011 (comment) for details.

@koushiro koushiro requested a review from sorpaas as a code owner March 7, 2023 06:33
@koushiro
Copy link
Collaborator Author

koushiro commented Mar 7, 2023

@sorpaas BTW, I don't see any use of PreLog by now, does it need to be removed?

frame/ethereum/src/lib.rs Outdated Show resolved Hide resolved
frame/ethereum/src/lib.rs Outdated Show resolved Hide resolved
@koushiro koushiro requested a review from sorpaas March 7, 2023 10:10
@sorpaas
Copy link
Member

sorpaas commented Mar 7, 2023

I don't see any use of PreLog by now, does it need to be removed?

That's reserved for situation when migrating a full Ethereum(-like) blockchain over to Substrate, or building an oracle. I'd prefer to keep it because it might be difficult to add it back in the future otherwise.

@sorpaas sorpaas merged commit 98aacf6 into polkadot-evm:master Mar 7, 2023
@koushiro koushiro deleted the support-new-postlog branch March 7, 2023 11:20
@koushiro
Copy link
Collaborator Author

koushiro commented Mar 7, 2023

cc @tgmichel

Dinonard pushed a commit to AstarNetwork/frontier that referenced this pull request Mar 22, 2023
…clude in the PostLog (polkadot-evm#1014)

* feat: provide a parameter for the runtime config to choose what to include in the PostLog

* use parameter_types macro

* fix on_finalize
@tdelabro
Copy link

@sorpaas @tgmichel

How do you speed up the syncing while using PreLog?

I mean, you don't want to wait the full block time each time you are importing a new block. You want to run the on_initialize and then immediately the on_finalize, without waiting for any transaction to come.

Is there an example of a client code that used it? Somewhere on a branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants