Add pending support for eth_getBlockByNumber
#1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
reviewed
May 25, 2023
| .validated_pool() | ||
| .ready() | ||
| .map(|in_pool_tx| in_pool_tx.data().clone()) | ||
| .collect::<Vec<<B as BlockT>::Extrinsic>>(), |
There was a problem hiding this comment.
Suggested change
| .collect::<Vec<<B as BlockT>::Extrinsic>>(), | |
| .collect::<Vec<_>>(), |
koushiro
reviewed
May 25, 2023
| .futures() | ||
| .iter() | ||
| .map(|(_hash, extrinsic)| extrinsic.clone()) | ||
| .collect::<Vec<<B as BlockT>::Extrinsic>>(), |
There was a problem hiding this comment.
Suggested change
| .collect::<Vec<<B as BlockT>::Extrinsic>>(), | |
| .collect::<Vec<_>>(), |
koushiro
reviewed
May 25, 2023
|
@tgmichel could u resolve the conflicts? I wanna this PR could be included in the polkadot-0.9.42 branch. |
# Conflicts: # client/rpc/src/eth/block.rs # template/runtime/src/lib.rs
sorpaas
approved these changes
Jun 23, 2023
koushiro
pushed a commit
to alt-research/frontier
that referenced
this pull request
Jul 12, 2023
* Add `pending` support for `eth_getBlockByNumber` * header not needed * cleanup * prettier * update some fields to be optional on pending * update test * cleanup
1 task
Closed
37 tasks
Closed
46 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
BlockNumber::Earliestas part ofeth_getBlockByNumberrpc returnsNone. This pr adds support for it adding a new runtime api that applies the current pool and finalizespallet-ethereum, returning the overlayed/pending ethereum block and statuses.