fix prefunded accounts for proper development experience on PolkadotJS Apps #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
reviewed
May 15, 2023
Comment on lines
+55
to
63
| #[allow(dead_code)] | ||
| type AccountPublic = <Signature as Verify>::Signer; | ||
|
|
||
| /// Generate an account ID from seed. | ||
| /// For use with `AccountId32`, `dead_code` if `AccountId20`. | ||
| #[allow(dead_code)] | ||
| pub fn get_account_id_from_seed<TPublic: Public>(seed: &str) -> AccountId | ||
| where | ||
| AccountPublic: From<<TPublic::Pair as Pair>::Public>, |
There was a problem hiding this comment.
why not remove these dead code?
There was a problem hiding this comment.
The template is usually the main reference newcomers use to figure out how to use the Frontier crates.
I didn't want to get rid of the code that could potentially be used when someone wants to use AccountId32, and that's why I left this get_account_id_from_seed there.
Maybe the ideal solution would be to have two templates? One showcasing the usage of AccountId20 and the other AccountId32. Downside is double effort for maintaing two runtimes.
wdyt @sorpaas ?
There was a problem hiding this comment.
Yeah but we probably should add some docs explaining this.
sorpaas
approved these changes
May 21, 2023
ashutoshvarma
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
May 29, 2023
…S Apps (polkadot-evm#1053) * add eth prefunded accounts to template * fix Account Lookup * rm unnecessary mut * fix prefunded accounts + sudo * taplo format * clippy * lint hex_literal import
ashutoshvarma
pushed a commit
to AstarNetwork/frontier
that referenced
this pull request
Jun 8, 2023
…S Apps (polkadot-evm#1053) * add eth prefunded accounts to template * fix Account Lookup * rm unnecessary mut * fix prefunded accounts + sudo * taplo format * clippy * lint hex_literal import
girazoki
pushed a commit
to moondance-labs/frontier
that referenced
this pull request
Jun 19, 2023
…S Apps (polkadot-evm#1053) * add eth prefunded accounts to template * fix Account Lookup * rm unnecessary mut * fix prefunded accounts + sudo * taplo format * clippy * lint hex_literal import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation I realized that my work on #1019 was incomplete.
This PR allows for a proper development experience on PolkadotJS Apps