[#1107] Using DefaultBaseFeePerGas * T::Threshold::ideal() as base_fee floor value.
#1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
approved these changes
Jul 24, 2023
arturgontijo
changed the title
DefaultBaseFeePerGas as base_fee floor value.DefaultBaseFeePerGas * T::Threshold::ideal() as base_fee floor value.
girazoki
pushed a commit
to moondance-labs/frontier
that referenced
this pull request
Aug 23, 2023
…()` as `base_fee` floor value. (polkadot-evm#1115) * [polkadot-evm#1107] Using DefaultBaseFeePerGas as base_fee floor value. * [polkadot-evm#1107] Fix tests + if-else * [polkadot-evm#1107] lowest_base_fee = default_base_fee * Threshold::ideal() * [polkadot-evm#1107] fmt
noandrea
pushed a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Aug 28, 2023
…()` as `base_fee` floor value. (polkadot-evm#1115) * [polkadot-evm#1107] Using DefaultBaseFeePerGas as base_fee floor value. * [polkadot-evm#1107] Fix tests + if-else * [polkadot-evm#1107] lowest_base_fee = default_base_fee * Threshold::ideal() * [polkadot-evm#1107] fmt
Closed
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea to solve #1107
Changed the logic to set a lowest
base_feetoDefaultBaseFeePerGas * T::Threshold::ideal()as it makes sense to start a chain using theDefaultBaseFeePerGasand decrease it till a floor value.If that works, I can go ahead an fix/update the tests.