Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy support #643

Merged
merged 21 commits into from
May 11, 2022
Merged

Add clippy support #643

merged 21 commits into from
May 11, 2022

Conversation

koushiro
Copy link
Collaborator

@koushiro koushiro commented Apr 26, 2022

Close #433

waiting for #653 and #648 to be merged firstly

@koushiro koushiro requested a review from sorpaas as a code owner April 26, 2022 11:29
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@sorpaas
Copy link
Member

sorpaas commented May 11, 2022

Please pull master.

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro
Copy link
Collaborator Author

koushiro commented May 11, 2022

@sorpaas PTAL

And could you cherry-pick #648 and this PR to polkadot-v0.9.19 branch

@sorpaas sorpaas merged commit 2bf0a5b into polkadot-evm:master May 11, 2022
@sorpaas
Copy link
Member

sorpaas commented May 11, 2022

And could you cherry-pick #648 and this PR to polkadot-v0.9.19 branch

I'd prefer not to. Release branches should only cherry pick security PRs.

Those new changes will come on polkadot-v0.9.20 branch.

@koushiro
Copy link
Collaborator Author

And could you cherry-pick #648 and this PR to polkadot-v0.9.19 branch

I'd prefer not to. Release branches should only cherry pick security PRs.

Those new changes will come on polkadot-v0.9.20 branch.

ok, make sense

@koushiro koushiro deleted the add-clippy-support branch May 11, 2022 08:13
koushiro added a commit to alt-research/frontier that referenced this pull request May 12, 2022
* fp-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* pallet-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* fc-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* template: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add clippy support for CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix rpc-core

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Improve CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add clippy component

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make test more stable

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
abhijeetbhagat pushed a commit to web3labs/frontier that referenced this pull request Jan 11, 2023
* fp-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* pallet-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* fc-*: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* template: make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add clippy support for CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix rpc-core

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Improve CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Add clippy component

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make test more stable

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Make clippy happy

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Fix CI

Signed-off-by: koushiro <koushiro.cqx@gmail.com>

* Some nits

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants