Enable async backing for system parachains #266
Conversation
I think there is no need to change Please, try to change this |
|
@bkontur hmmm, it's not in 0.8.0 |
hmm, sorry, I didn't check the version. I would not bump here (you could run into the other issues with incompatibility...), |
| @@ -196,7 +196,7 @@ impl pallet_timestamp::Config for Runtime { | |||
| /// A timestamp: milliseconds since the unix epoch. | |||
| type Moment = u64; | |||
| type OnTimestampSet = Aura; | |||
| type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>; | |||
| type MinimumPeriod = ConstU64<0>; | |||
There was a problem hiding this comment.
is this a tmp value or is it going to be zero?
There was a problem hiding this comment.
IIUC, we don't need to set the minimum period anymore. With async backing at higher velocities, we may produce more blocks per slot, and nothing stops us from producing more than two blocks per slot, so this limit doesn't make sense, and I set it to zero here. But maybe some of the senior fellows will correct me.
There was a problem hiding this comment.
If that's the case then I need to figure out how to deal with it on chopsticks
system-parachains/bridge-hubs/bridge-hub-kusama/primitives/src/lib.rs
Outdated
Show resolved
Hide resolved
|
Before we are doing this, we need to review that all these chains are capable of running with 6seconds. I mean that stuff that maybe has timeout measured in blocks would be broken by this. |
|
CC @ggwpez |
|
We can't change the block time without ensuring every pallet used by each runtime are dynamic block time friendly |
|
Okay, so it's not that easy. Maybe I could create separate PRs for different parachains, then? Do we have any parachains that definitely can be switched to 6s block times without side effects? The point is, we have teams in the ecosystem waiting for at least something running with 6s block times on mainnets. The sooner we show it works, the sooner they'll catch up. And sorting out the timing issue may take quite some time, I'm afraid. |
|
there is good chance no existing ecosystem parachain can enable 6s block time because none of the existing governance pallet supports changing block time |
Look at the chains, their pallets and if they depend on block number for tracking stuff. |
But governance does support runtime upgrades, and we have |
What Bryan meant is that governance logic uses the block number to measure time. Most of the stuff is using/used block number for time. This is the problem we are facing here. |
Oh I see. Still, it's a shame we noticed the problem, we could otherwise get two fellowship salaries a month 🤣 |
|
Okay, I went through the existing system parachains, and indeed, most of them require resolving timing issues. But what about the |
Agree, People should be fine as long as constants like |
This is an excerpt from #266. It aims to enable 6-second block times for `people` parachain only. If I'm not missing anything, the `people` parachain is the only parachain not affected by paritytech/polkadot-sdk#3268, and thus, 6-second block times may be enabled without breaking something. This PR was tested locally using the `kusama-local` relay chain. The time of the session within which the runtime upgrade was enacted expectedly deviated, but other than that, no problems were observed. --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
|
@s0me0ne-unkn0wn can you please convert this into an issue. No need to keep the pr open. |
This enables async backing with 6 sec block times for all the system parachains on both Kusama and Polkadot.