Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up-to-date action can be activated by auto-merge-bot #272

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Apr 10, 2024

@Bullrich Bullrich force-pushed the auto-merge/enable-up-to-date branch from 5283d4c to 496df37 Compare April 22, 2024 08:09
@Bullrich
Copy link
Contributor Author

/merge

1 similar comment
@Bullrich
Copy link
Contributor Author

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) April 24, 2024 12:47
Linked actions so that, when auto-merge is enabled, it will trigger up-to-date to update every PR (including this one)

Resolves paritytech/up-to-date-action#14
This latest change include paritytech/up-to-date-action#17 which stops the action from updating PRs which are already up to date
Let's use github's tools when possible as they _should_ be more secure
auto-merge was automatically disabled April 24, 2024 12:48

Head branch was pushed to by a user without write access

@Bullrich Bullrich force-pushed the auto-merge/enable-up-to-date branch from 496df37 to 3dd6c96 Compare April 24, 2024 12:48
@Bullrich
Copy link
Contributor Author

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) April 24, 2024 12:49
@fellowship-merge-bot
Copy link
Contributor

Failed to update PR ❌

There was an error while trying to keep this PR up-to-date

You may have conflicts ‼️ or may have to manually sync it with the target branch 👉❇️

More info in the logs 📋

@Bullrich
Copy link
Contributor Author

Bullrich commented May 7, 2024

Hi! This PR is still waiting for an approval.

Can a rank 3 or above please look into it?

CC to possible reviewers:
@kianenigma
@tomaka
@xlc
@arkpar
@ordian
@noot

@fellowship-merge-bot fellowship-merge-bot bot merged commit 2663a3a into polkadot-fellows:main May 7, 2024
37 checks passed
@Bullrich Bullrich deleted the auto-merge/enable-up-to-date branch May 7, 2024 15:10
Bullrich added a commit to Bullrich/polkadot-fellows-runtimes that referenced this pull request May 21, 2024
As explained in paritytech/up-to-date-action#18, the issue is caused because the `skipped` event is treated as `completed`. Until a better solution is generated, let's remove this event and triggered it only in pushes.

This reverts polkadot-fellows#272
fellowship-merge-bot bot pushed a commit that referenced this pull request May 22, 2024
As explained in
paritytech/up-to-date-action#18 (comment),
the issue is caused because the `skipped` event is treated as
`completed`. Until a better solution is generated, let's remove this
event and trigger it only in pushes.

This reverts #272

- [x] Does not require a CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

up-to-date action should be activated by auto-merge-bot
4 participants