Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add establish_channel_with_system to the HRMP pallet #329

Merged
merged 5 commits into from
May 29, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented May 27, 2024

Allows any parachain to have bidirectional channel with any system parachains.

Relates to: polkadot-fellows/RFCs#82
Relates to: paritytech/polkadot-sdk#3721
Relates to: paritytech/polkadot-sdk#4332

  • regenerate weights for runtime_parachains::hrmp
  • Does not require a CHANGELOG entry

Polkadot weights

(the threshold moved from the default 5 to 0.1 to see some differences)

subweight compare commits          --path-pattern "./relay/polkadot/**/weights/**/*.rs"          --format markdown --no-color           --change added changed          --method asymptotic --ignore-errors --threshold 0.1          remotes/polkadot-fellows/main          origin/bko-hrmp-patch
File Extrinsic Old New Change [%]
relay/polkadot/src/weights/runtime_parachains_hrmp.rs poke_channel_deposits 137.20us 140.03us +2.06
relay/polkadot/src/weights/runtime_parachains_hrmp.rs hrmp_accept_open_channel 555.89us 563.03us +1.28
relay/polkadot/src/weights/runtime_parachains_hrmp.rs hrmp_close_channel 556.97us 563.79us +1.22
relay/polkadot/src/weights/runtime_parachains_hrmp.rs hrmp_init_open_channel 732.03us 740.10us +1.10
relay/polkadot/src/weights/runtime_parachains_hrmp.rs force_open_hrmp_channel 1.16ms 1.17ms +0.98
relay/polkadot/src/weights/runtime_parachains_hrmp.rs establish_system_channel 1.15ms 1.16ms +0.69
relay/polkadot/src/weights/runtime_parachains_hrmp.rs force_process_hrmp_open 102.05ms 102.47ms +0.42
relay/polkadot/src/weights/runtime_parachains_hrmp.rs force_clean_hrmp 91.52ms 91.86ms +0.37
relay/polkadot/src/weights/runtime_parachains_hrmp.rs clean_open_channel_requests 16.56ms 16.61ms +0.35
relay/polkadot/src/weights/runtime_parachains_hrmp.rs force_process_hrmp_close 75.41ms 75.65ms +0.33
relay/polkadot/src/weights/runtime_parachains_hrmp.rs hrmp_cancel_open_request 422.12us 415.03us -1.68
relay/polkadot/src/weights/runtime_parachains_hrmp.rs establish_channel_with_system 1.67ms Added

Kusama weights

(the threshold moved from the default 5 to 0.1 to see some differences)

subweight compare commits          --path-pattern "./relay/kusama/**/weights/**/*.rs"          --format markdown --no-color           --change added changed          --method asymptotic --ignore-errors --threshold 0.1          remotes/polkadot-fellows/main          origin/bko-hrmp-patch
File Extrinsic Old New Change [%]
relay/kusama/src/weights/runtime_parachains_hrmp.rs poke_channel_deposits 137.23us 140.25us +2.20
relay/kusama/src/weights/runtime_parachains_hrmp.rs hrmp_close_channel 557.39us 564.18us +1.22
relay/kusama/src/weights/runtime_parachains_hrmp.rs hrmp_accept_open_channel 556.49us 563.23us +1.21
relay/kusama/src/weights/runtime_parachains_hrmp.rs hrmp_init_open_channel 735.26us 743.59us +1.13
relay/kusama/src/weights/runtime_parachains_hrmp.rs force_open_hrmp_channel 1.16ms 1.17ms +0.97
relay/kusama/src/weights/runtime_parachains_hrmp.rs establish_system_channel 1.15ms 1.16ms +0.84
relay/kusama/src/weights/runtime_parachains_hrmp.rs hrmp_cancel_open_request 413.79us 416.03us +0.54
relay/kusama/src/weights/runtime_parachains_hrmp.rs force_process_hrmp_open 101.96ms 102.43ms +0.46
relay/kusama/src/weights/runtime_parachains_hrmp.rs clean_open_channel_requests 16.54ms 16.61ms +0.45
relay/kusama/src/weights/runtime_parachains_hrmp.rs force_clean_hrmp 91.43ms 91.82ms +0.43
relay/kusama/src/weights/runtime_parachains_hrmp.rs force_process_hrmp_close 75.34ms 75.63ms +0.40
relay/kusama/src/weights/runtime_parachains_hrmp.rs establish_channel_with_system 1.67ms Added

@bkontur bkontur marked this pull request as ready for review May 27, 2024 12:50
@joepetrowski joepetrowski mentioned this pull request May 27, 2024
7 tasks
@acatangiu
Copy link
Contributor

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 8f44f91 into polkadot-fellows:main May 29, 2024
40 of 41 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkontur bkontur deleted the bko-hrmp-patch branch June 26, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants