CI: updated all deprecated actions #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bullrich
commented
Jul 24, 2024
| @@ -150,6 +150,7 @@ jobs: | |||
|
|
|||
| - name: Create release | |||
| id: create-release | |||
| # TODO: Replace as it has been deprecated | |||
There was a problem hiding this comment.
It seems that this should be replaced by gh cli.
Example solution:
- name: Create release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
tag: ${{ github.ref_name }}
run: |
gh release create "$tag" \
--repo="$GITHUB_REPOSITORY" \
--title="${GITHUB_REPOSITORY#*/} ${tag#v}" \
--generate-notesThere was a problem hiding this comment.
GitHub also showed some alternatives actions in the readme
Comment on lines
+187
to
189
| # TODO: Replace as it has been deprecated | ||
| uses: actions/upload-release-asset@v1 | ||
| env: |
There was a problem hiding this comment.
From the action's readme the new action that seems to replace this one is softprops/action-gh-release
bkchr
approved these changes
Jul 24, 2024
|
/merge |
|
Review required! Latest push from author must always be reviewed |
ggwpez
approved these changes
Jul 24, 2024
|
/merge |
fellowship-merge-bot
bot
merged commit 4eb5267
into
polkadot-fellows:main
44 of 45 checks passed
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed there are a lot of outdated actions with deprecated warnings:
This PR updates all of GitHub actions to latest version to remove such warnings.
I have also added some
TODOto actions that have been archived by GitHub and that require an alternative action/solution. We can do that in a different PR once we identify the correct solution.