Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added review-bot #66

Merged
merged 2 commits into from
Jun 28, 2024
Merged

added review-bot #66

merged 2 commits into from
Jun 28, 2024

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Jun 27, 2024

Now that #65 has been resolved, review-bot can be implemented.

I copied the workflow files from the runtimes repository.

Resolves #62

The following configuration has been writen in the file, but it can be changed if you disagree with the rules:

CI Files

Requires 1 dan 3 to review it and a total of 15 points to merge.

Some possible combinations are:

  • 1 dan6
  • 1 dan5 & 1 dan3
  • 3 dan3
  • 1 dan4 & 1 dan3 & 1 dan2

General files

Requires at least 2 dan 2 to review it and a total of 10 points to merge.

Some possible combinations are:

  • 1 dan5 & any rank
  • 2 dan3.
  • 5 dan2.
  • 1 dan2 and 8 dan1.

Now that polkadot-fellows#65 has been resolved, review-bot can be implemented.

The following configuration has been provided in the file, but it can be changed if you disagree with the content:

### CI Files
Requires **1 dan 3** to review it and a total of **15 points** to merge.

Some possible combinations are:
- 1 dan6
- 1 dan5 & 1 dan3
- 3 dan3
- 1 dan4 & 1 dan3 & 1 dan2

### Proposals
Requires at least **2 dan 2** to review it and a total of **10 points** to merge.

Some possible combinations are:
- 1 `dan5` && any rank
- 2 `dan3`.
- 5 `dan2`.
- 1 `dan2` and 8 `dan1`.

### General files
Requires at least **2 dan 1** to review it and a total of **4 points** to merge.

Some possible combinations are:
- 1 `dan3` or above.
- 4 `dan1`.
- 2 `dan2`.
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not allowed to approve or request changes, only comment.

@bkchr looks like you need to tweak the repo settings a bit - probably currently set to only allow reviews from "collaborators/members".

.github/review-bot.yml Outdated Show resolved Hide resolved
.github/review-bot.yml Outdated Show resolved Hide resolved
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@Bullrich Bullrich requested a review from acatangiu June 27, 2024 17:18
@bkchr
Copy link
Contributor

bkchr commented Jun 28, 2024

@acatangiu please try again. Should be fixed.

@acatangiu
Copy link
Contributor

/merge

@acatangiu
Copy link
Contributor

@Bullrich can we get the merge-bot too? 🙈 ^

@Bullrich
Copy link
Contributor Author

@Bullrich can we get the merge-bot too? 🙈 ^

I was about to ask, should I add both auto-merge-bot and up-to-date?

@bkchr
Copy link
Contributor

bkchr commented Jun 28, 2024

@Bullrich can we get the merge-bot too? 🙈 ^

I was about to ask, should I add both auto-merge-bot and up-to-date?

Yes please.

@Bullrich
Copy link
Contributor Author

I created #68, but it is blocked until #67 is resolved.

@bkchr I added a step-by-step guide on how to properly get the secrets

@Bullrich
Copy link
Contributor Author

I would recommend to merge this PR before #68 as the auto-merge functionality without some kind of security checks (review-bot) could be dangerous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy the CI tooling from the RFC repo
3 participants