-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added review-bot #66
added review-bot #66
Conversation
Now that polkadot-fellows#65 has been resolved, review-bot can be implemented. The following configuration has been provided in the file, but it can be changed if you disagree with the content: ### CI Files Requires **1 dan 3** to review it and a total of **15 points** to merge. Some possible combinations are: - 1 dan6 - 1 dan5 & 1 dan3 - 3 dan3 - 1 dan4 & 1 dan3 & 1 dan2 ### Proposals Requires at least **2 dan 2** to review it and a total of **10 points** to merge. Some possible combinations are: - 1 `dan5` && any rank - 2 `dan3`. - 5 `dan2`. - 1 `dan2` and 8 `dan1`. ### General files Requires at least **2 dan 1** to review it and a total of **4 points** to merge. Some possible combinations are: - 1 `dan3` or above. - 4 `dan1`. - 2 `dan2`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not allowed to approve or request changes, only comment.
@bkchr looks like you need to tweak the repo settings a bit - probably currently set to only allow reviews from "collaborators/members".
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@acatangiu please try again. Should be fixed. |
/merge |
@Bullrich can we get the merge-bot too? 🙈 ^ |
I was about to ask, should I add both auto-merge-bot and up-to-date? |
Yes please. |
I would recommend to merge this PR before #68 as the auto-merge functionality without some kind of security checks (review-bot) could be dangerous |
Now that #65 has been resolved, review-bot can be implemented.
I copied the workflow files from the
runtimes
repository.Resolves #62
The following configuration has been writen in the file, but it can be changed if you disagree with the rules:
CI Files
Requires 1 dan 3 to review it and a total of 15 points to merge.
Some possible combinations are:
dan6
dan5
& 1dan3
dan3
dan4
& 1dan3
&1 dan2
General files
Requires at least 2 dan 2 to review it and a total of 10 points to merge.
Some possible combinations are:
dan5
& any rankdan3
.dan2
.dan2
and 8dan1
.