Do not rely on balances pallet or particular type for AccountInfo #3669
Conversation
| @@ -19,9 +19,13 @@ interface Result { | |||
| } | |||
|
|
|||
| function latestNonce (api: ApiInterfaceRx, address: string): Observable<Index> { | |||
| return api.derive.balances.account(address).pipe( | |||
There was a problem hiding this comment.
This cannot be dropped - it means others for existing chains are not available anymore. To put this in context, with chains with system.account the nonce is stored there, so basically this PR will always return a zero index in those cases, which means the greater part of deployed chains won't work as-is.
In #3672 the checks are adjusted at the correct level, i.e. adjust the checks correctly with optional chaining and don't assume that when balances.account is not there, balances.freeBalances will be. (Same for system.accountNonce)
|
Right now I'm encountering an issue that this PR seems to be looking to solve. There's an assumption made by this api client that the chain must use the Edit: I checked out this PR and it worked for me, was able to submit an extrinsic to our chain. |
|
Closing. The paymentInfo derive does not rely on balances anymore. Rather the |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.