Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust known lookup with support for [u8;32] #5764

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Adjust known lookup with support for [u8;32] #5764

merged 1 commit into from
Dec 18, 2023

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Nov 26, 2023

Closes #5760

@ironoa
Copy link

ironoa commented Dec 4, 2023

I am having this Unable to map [u8; 32] to a lookup index error when I try to perform api.events.x.y.is(event), for example: api.events.referenda.Submitted.is(event). I had to rollback to the api version v9.14.2

@wottpal
Copy link

wottpal commented Dec 4, 2023

I think there just has not been a new release since this fix yet.

@ironoa
Copy link

ironoa commented Dec 4, 2023

I think there just has not been a new release since this fix yet.

But if this is the fix, it hasn’t been merged anyway, no ?

@0xmovses
Copy link

0xmovses commented Dec 6, 2023

Can we get this merged? It's blocking me building out new e2e substrate test infra with chopsticks.

@rlaferla
Copy link

Is this going to get merged? We are seeing this annoying error message as well.

JoeCap08055
JoeCap08055 reviewed Dec 12, 2023
View reviewed changes
packages/types/src/metadata/decorate/storage/util.ts
@@ -18,8 +20,8 @@ interface ManualDefinition {
section: string;
}

function findSiPrimitive (registry: Registry, _prim: string): PortableType | undefined {
const prim = _prim.toLowerCase();
function findSiPrimitive (registry: Registry, type: string): PortableType | undefined {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: type is a keyword in Typescript; I'd suggest using a different identifier

@jacogr jacogr added the -auto label Dec 18, 2023
@polkadot-js-bot polkadot-js-bot merged commit 46c00d4 into master Dec 18, 2023
6 checks passed
@polkadot-js-bot polkadot-js-bot deleted the jg-fix-known-lookup branch December 18, 2023 07:03
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 left review comments

Assignees
No one assigned
Labels
-auto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ApiPromise prints an error message when initializing
7 participants
@jacogr @ironoa @wottpal @0xmovses @rlaferla @polkadot-js-bot @JoeCap08055