Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep assetID hex as Option for toPayload #5968

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Keep assetID hex as Option for toPayload #5968

merged 6 commits into from
Sep 5, 2024

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Sep 3, 2024

ref: #5967

This ensures that the HexString that is part of the SignerPayloadJSON is an Option.

@TarikGul
Copy link
Member Author

TarikGul commented Sep 3, 2024

So I tested this locally to send Assets over xcm with usdt as a asset to pay fees with and I am getting a wasm trap error:

2024-09-03 18:10:41        RPC-CORE: submitExtrinsic(extrinsic: Extrinsic): Hash:: 1002: Verification Error: Runtime error: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x3f78ac - <unknown>!rust_begin_unwind
    1: 0x2113 - <unknown>!core::panicking::panic_fmt::hbb5a6b42001bdfec
    2: 0x34d3c8 - <unknown>!TaggedTransactionQueue_validate_transaction: RuntimeApi, Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instruction executed\nWASM backtrace:\nerror while executing at wasm backtrace:\n    0: 0x3f78ac - <unknown>!rust_begin_unwind\n    1: 0x2113 - <unknown>!core::pa…

@TarikGul
Copy link
Member Author

TarikGul commented Sep 3, 2024

The wasm trap issue above is fixed, but fees are not getting payed with usdt, but instead keeps defaulting to ksm... That being said I don't think that is a result of this PR!

Copy link

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very hacky, LGTM! 🚀

Copy link
Member

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TarikGul TarikGul merged commit 1f751e0 into master Sep 5, 2024
4 checks passed
@TarikGul TarikGul deleted the tg-no-unwrap branch September 5, 2024 13:06
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants