Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay Chain - Coretime Overview UI Tab #11016

Merged
merged 25 commits into from
Oct 22, 2024
Merged

Relay Chain - Coretime Overview UI Tab #11016

merged 25 commits into from
Oct 22, 2024

Conversation

piggydoughnut
Copy link
Contributor

@piggydoughnut piggydoughnut commented Oct 16, 2024 •
edited
Loading

Relay chain

NOTE: 17th October is the end of the 1st cycle for Polkadot, and I want to test see how the table behaves at that moment, so for now the PR is in draft

This PR separates Coretime Chain - Overview UI Tab from this #10383

Original Feature Request : #10285

Relay chain does not provide enough information to show, so we are using Coretime Endpoints to get extra information in order to provide better user experience.

Changes:

  • Exposing Coretime endpoint so it can be used from any chain now, just like the People endpoint

Parachain table:

  • Renewal and Renewal price are only shown if there is a record for the given chain in the potentialRenewals calls from broker pallet.

Unrelated changes:

  • Updated names for Paseo networks to start with Paseo, as we filter by it at some occasions
Screenshot 2024-10-16 at 19 52 31

Coretime Chain

Coretime chain Overview Tab also got small updates.

  • added colourful labels
  • new summary items: cycle dates and cycle progress
Screenshot 2024-10-16 at 19 54 52

Closes #10383

@piggydoughnut
exposing coretime wss endpoint to use on relay chain, adjusted hooks …
18e46a9 
…to accept api endpoint as a parameter
@piggydoughnut
adjusting hook calls to new parameters
94a4329
@piggydoughnut
added Tag for coretime types, renamed occupancyType to coretimeType
ec64d75
@piggydoughnut
added cycle progress and cycle end date to summary, fixed the estimat…
2500205 
…ion dates
@piggydoughnut
coretime page draft, added hook for gathering all the coretime inform…
1913d17 
…ation in order to show it on relay chain
@piggydoughnut
Merge branch 'master' into dm-coretime-ui-relay
de1f7f9
@piggydoughnut
lint
92b5216
@piggydoughnut
Merge branch 'master' into dm-coretime-ui-relay
88e762d
@piggydoughnut
bumped version
7eec0b7
@piggydoughnut
updated coretime chain summary
19ee4e0
@piggydoughnut
updated summary, added timeslice for the first sale start,
7bb556f
@piggydoughnut
hook updates to make sure the coretime data is displayed even if work…
17fa09b 
…loads are empty, fallback on coreAssignments
@piggydoughnut
removed unused files
56bbcfa
@piggydoughnut
lint
da7be71
@piggydoughnut piggydoughnut marked this pull request as draft October 16, 2024 11:53
@TarikGul
Copy link
Member

looks really great so far!

@piggydoughnut
Copy link
Contributor Author

@TarikGul it is ready for you 😊 Thank you.

@piggydoughnut piggydoughnut marked this pull request as ready for review October 18, 2024 09:26
TarikGul
TarikGul reviewed Oct 22, 2024
View reviewed changes
packages/page-broker/src/utils.ts Outdated
* @param regionLength
* @returns
*/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

TarikGul
TarikGul approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@TarikGul TarikGul merged commit 4df5c9a into master Oct 22, 2024
5 checks passed
@TarikGul TarikGul deleted the dm-coretime-ui-relay branch October 22, 2024 13:38
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piggydoughnut @TarikGul @polkadot-js-bot