Fix office results containing alternates #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue getting office results for code
2248524
. The problem was unlikepostaldata.json
, alternates inofficedata.json
were missing thealternates
field. This resulted in the following error when instantiating OfficeCodeBase for each alternate:My original approach was to modify the results at run time, but in the end I went with modifying prep.py to always include alternates and updated the office data. Let me know if you prefer another approach.
Also renamed a test that was shadowing another one with the same name.