Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with missing message collector #159

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

justinpolygon
Copy link
Contributor

@justinpolygon justinpolygon commented Jan 3, 2024

Fixes #144. Added missing message collector for websocket event.

No messages were coming through when running the KotlinStocksWebsocketSample.kt via KotlinUsageSample.kt when stocksWebsocketSample(polygonKey) was uncommented. After fixing this bug and rerunning you'll see events being passed correctly (like below).

...
Receieved Message: Trade(eventType=T, ticker=ACN, exchangeId=4, tradeId=71697218885707, tape=1, price=339.47, size=6.0, conditions=[37], timestampMillis=1704310583363, sequenceNumber=1338647, trf=202, trfTimestampMillis=1704310583363)
Receieved Message: Trade(eventType=T, ticker=LLY, exchangeId=4, tradeId=71697218885699, tape=1, price=617.97, size=1.0, conditions=[37], timestampMillis=1704310583349, sequenceNumber=1932601, trf=202, trfTimestampMillis=1704310583349)
Receieved Message: Trade(eventType=T, ticker=XOM, exchangeId=4, tradeId=71697218885199, tape=1, price=103.385, size=100.0, conditions=[], timestampMillis=1704310583254, sequenceNumber=2003481, trf=202, trfTimestampMillis=1704310583254)
...

Copy link
Contributor

@mmoghaddam385 mmoghaddam385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof good catch

@justinpolygon justinpolygon merged commit 3ad9ed1 into master Jan 3, 2024
1 check passed
@justinpolygon justinpolygon deleted the jw-add-message-collector branch January 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in PolygonWebSocketClient implementation
2 participants