Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it clear when modification residues might have been updated #2121

Closed
ValWood opened this issue Dec 11, 2023 · 11 comments
Closed

Making it clear when modification residues might have been updated #2121

ValWood opened this issue Dec 11, 2023 · 11 comments

Comments

@ValWood
Copy link
Member

ValWood commented Dec 11, 2023

Nurse lab reported difficulty in knowing when modifications have changed:

Add a warning to the top of the modification section for all genes with new coordinates

Show short text:
Warning - residue position changes more......

Expand to full text:
"warning, the protein sequence of this feature has changed during its history, and any affected modification residues were mapped over to the new coordinates. The residues displayed here may be revised compared to the original residues described in the publications below. Please see the "gene structure history section" for sequence coordinate change(s) details.

Later we might see if we can put this information in a mouse over "previously blah"

@kimrutherford
Copy link
Member

Note to self: put notice at top of modification sections if the gene structure has changed in the past.

@ValWood
Copy link
Member Author

ValWood commented Feb 12, 2024

Additional text for
https://www.pombase.org/documentation/gene-page-modifications

The residue(s) modified (where available).

Add
Note that the PomBase reported residues may differ from the published residues in cases where the gene structure coordinates have changed. In these cases we remap the modification to the new residue number. If it is possible that residue numbers have changed for a given protein there is a warning at the top of the protein modification section.

@kimrutherford
Copy link
Member

Done for the morning.

kimrutherford added a commit that referenced this issue Feb 12, 2024
@kimrutherford
Copy link
Member

Note to self: put notice at top of modification sections if the gene structure has changed in the past.

Here's what I have so far. Can you improve the message for me?

Note: The intron/exon structure of this gene has changed since the genome was published
so protein modifications positions from older studies may be incorrect 

It's running here:
https://desktop.kmr.nz/gene/SPAC1002.17c

image

@kimrutherford
Copy link
Member

Done for the morning.

I meant the changes to the docs rather than the message at the top of the modifications section.

@ValWood
Copy link
Member Author

ValWood commented Feb 13, 2024

Warning Note : The translation start or intron/exon structure of this gene has changed since the genome was published (see history section for change details) so protein Changed Modification positions from older studies may be incorrect have been revised to match their current amino acid location.

Is that OK? we can revise on call today.

kimrutherford added a commit to pombase/pombase-config that referenced this issue Feb 13, 2024
@kimrutherford
Copy link
Member

Thanks. I've added that message for tonight's load. I changed "history section" to "Gene structure history section".

@kimrutherford
Copy link
Member

I think this is done now.

@ValWood
Copy link
Member Author

ValWood commented Feb 14, 2024

I don't see the message on cdc18 modification section?

@ValWood ValWood reopened this Feb 14, 2024
@kimrutherford
Copy link
Member

The is no gene structure history for cdc18.

@ValWood
Copy link
Member Author

ValWood commented Feb 14, 2024

hmm, good point. I was thinking of cdc48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants