Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable targets exportation during build #150

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

wgoadri
Copy link

@wgoadri wgoadri commented Jul 23, 2024

close #149

@wgoadri
Copy link
Author

wgoadri commented Jul 23, 2024

@nmellado @azaleostu I modified the cmake exportation to make the targets available during the build. Now, projects that are exported can link to Ponca. The problem only appeared with libraries.

@wgoadri
Copy link
Author

wgoadri commented Jul 23, 2024

I also did a bit of work on the installation folder to add the Ponca name. If Ponca is installed by another project, this makes the install directory more structured. It should not interfere with the previous installation because of the cmake find_package procedure.

Also, I think that the installation paths could be shared by the cmake files, they are currently hard coded.

Copy link
Contributor

@azaleostu azaleostu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the changelog as this might break existing installs, otherwise looks good 👍

@nmellado nmellado self-assigned this Aug 29, 2024
@nmellado
Copy link
Contributor

I need to understand why the tests didn't start.

@wgoadri
Copy link
Author

wgoadri commented Aug 30, 2024

I think you need to approve the PR to trigger the action because I am not a contributor.
To avoid this, the workflow can use the pull_request_target event that allows fork from anyone to trigger the test with a pr from a fork. But it is not secure.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories
actions/add-to-project#163

@nmellado nmellado merged commit 045d6c2 into poncateam:master Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable exportation of Ponca during build when linked using add_subdirectory
3 participants