Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to make untrunc work with a video containing lots of 0-bytes at the end #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small fixes to make untrunc work with a video containing lots of 0-bytes at the end #117

wants to merge 1 commit into from

Conversation

davitf
Copy link

@davitf davitf commented Jun 6, 2018

atom.cpp:

  • Fix buffer reuse logic in getFragment(). (speeds up considerably when skipping over large blocks of zeros)
  • Fix "Out of buffer" crash in readInt() when reading near the end of the file. (needed for a previous version of the fix; probably a no-op now, but seems safer for the future)

mp4.cpp:

  • Fix crash when the offset is < 4 bytes from the end of the block, i.e. a full int cannot be read.

@davitf
Small fixes to make untrunc work with a video containing lots of 0-by…
ffb38ee 
…tes at the end.

atom.cpp:
- Fix buffer reuse logic in getFragment(). (speeds up considerably when skipping over large blocks of zeros)
- Fix "Out of buffer" crash in readInt() when reading near the end of the file. (needed for a previous version of the fix; probably a no-op now, but seems safer for the future)

mp4.cpp:
- Fix crash when the offset is < 4 bytes from the end of the block, i.e. a full int cannot be read.
@anthwlock
Copy link

I would appreciate it if you could find some time to test if this bug is still present in my master

@davitf
Copy link
Author

davitf commented Jun 7, 2018

Hi anthwlock, I've tested it. The process completes successfully, but for some reason the resulting video does not play correctly... I could send you my reference and broken videos if you'd like to test it.

@anthwlock
Copy link

Yes, that would be great! Open a Issue on my repository please.

@davitf davitf mentioned this pull request Jun 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davitf @anthwlock